Skip to content

Review podman examples - #166

Merged
ikke-t merged 4 commits into
LibreBooking:masterfrom
colisee:podman
Mar 7, 2026
Merged

Review podman examples#166
ikke-t merged 4 commits into
LibreBooking:masterfrom
colisee:podman

Conversation

@colisee

@colisee colisee commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator

Changes

  • Switch podman cli example to a pod utilization from a network utilization
  • Add an example of utilization with a pod-kind Kubernetes yaml file

@colisee
colisee requested a review from ikke-t March 6, 2026 09:13
@colisee colisee added the documentation Improvements or additions to documentation label Mar 6, 2026
@colisee colisee changed the title Reviw podman examples Review podman examples Mar 6, 2026
@ikke-t

ikke-t commented Mar 6, 2026

Copy link
Copy Markdown
Collaborator

I tested the changes and they do work. Now I would perhaps change the headers of the file. They say local access in some, some not. They are all 8080 port so none of them is more to local access than another one. Perhaps the word local could be removed, or it should be in all. I think it relates to the docker example having LB in front.

@ikke-t ikke-t left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the local in headers

@colisee

colisee commented Mar 7, 2026

Copy link
Copy Markdown
Collaborator Author

I agree with you. I will stop mentioning local access.

@ikke-t ikke-t left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the changes

@ikke-t
ikke-t merged commit bca960e into LibreBooking:master Mar 7, 2026
2 checks passed
@colisee
colisee deleted the podman branch May 26, 2026 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants